Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Browser fullscreen #778

Merged
merged 15 commits into from
Aug 26, 2023

Conversation

veggiecan0419
Copy link
Contributor

Blocks to interact with the browsers fullscreen
picture of the blocks

@veggiecan0419 veggiecan0419 marked this pull request as ready for review July 26, 2023 02:31
@CubesterYT
Copy link
Collaborator

This extension isn't necessary as my upcoming extension named Window Controls already has Fullscreen related blocks. #708

@veggiecan0419
Copy link
Contributor Author

This extension isn't necessary as my upcoming extension named Window Controls already has Fullscreen related blocks. #708

@CubesterYT
So should we remove it from the index.ejs?

@CubesterYT
Copy link
Collaborator

CubesterYT commented Aug 1, 2023

This extension isn't necessary as my upcoming extension named Window Controls already has Fullscreen related blocks. #708

@CubesterYT So should we remove it from the index.ejs?

@veggiecan0419, no way for me to say this without making it feel upfront or something, but this extension is just not needed at all since Window Controls has these functions. I guess there's nothing I can think since you asked what we should do, but the only thing I can think of is for you to close the PR.

@NexusKitten

This comment was marked as spam.

@LilyMakesThings

This comment was marked as off-topic.

@CubesterYT

This comment was marked as off-topic.

@NexusKitten

This comment was marked as off-topic.

@GarboMuffin
Copy link
Member

Made redundant by #708

@GarboMuffin GarboMuffin reopened this Aug 25, 2023
@GarboMuffin GarboMuffin merged commit a23d7ea into TurboWarp:master Aug 26, 2023
3 checks passed
@LilyMakesThings
Copy link
Contributor

Yay!!

BananaBake

This comment was marked as duplicate.

@veggiecan0419 veggiecan0419 deleted the BrowserFullscreen branch August 27, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants